Repository navigation
Conversation
yimi528
force-pushed
the
codex/pr-frontend-tool-activity
branch
from
September 19, 2026 15:51
66d22ab to
0b93dc2
Compare
This was referenced Sep 21, 2026
Collaborator
|
感谢你对工具调用可视化的贡献,也感谢此前同步主分支、移除 Windows 自动重试改动并补充测试。这项能力很有价值,限制展示记录数量、不保留原始参数与结果的处理也很合理。 这次审核发现,展示状态还需要进一步与实际执行语义对齐:
我们正在收尾 2.0,按维护者决定先关闭本 PR,不合并当前实现。这并不是否定功能方向;欢迎后续基于最新 main,修正上述状态语义并补充跨轮/打断场景测试后重新提交。再次感谢! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The presentation model keeps only bounded, non-content metadata: call id, surface
(
frontend/backend), tool name, status, timestamps/duration and an optionalerror code. Raw arguments and results are deliberately dropped, the retained call
list is capped at 64, and terminal states cannot be reverted by a late event.
Scope is web presentation plus the two protocol/contract docs lines that describe
tool.callas a presentation-only event. No Gateway, backend or client-statebehaviour is changed.
Update — rebased onto current
mainThe branch had drifted 8 days behind
main(385 files changed since the mergebase), so it was rebased onto
mainand force-pushed. Two things worth callingout:
CHANGELOG.md(kept both entries, new entry on top)and
.github/workflows/ci.yml. Both are resolved; the final diff is+550 / −13 across 12 files.
npm testretry commit that had been stacked on this branch wasdropped. That change was declined on its own merits in ci: retry Windows suite on silent test-process exits #422/ci: preserve Windows test crash diagnostics #442, so it does
not belong in this PR's scope.
ci.ymlis now untouched by this branch.Validation
Re-run locally on this rebased head (Windows, Node 24.11.0):
npm run test --workspace web— 158 passed, 0 failednpm run build— succeedednode --test server/test/realtime-gateway.test.mjs— 5 passed, 0 failednpx eslint .— cleanCloses #230
Closes #231